[Compute] Disk encryption set: add --enable-auto-key-rotation#17577
Merged
[Compute] Disk encryption set: add --enable-auto-key-rotation#17577
Conversation
qwordy
requested review from
Juliehzl,
evelyn-ys,
fengzhou-msft,
houk-ms,
jiasli,
jsntcy and
yungezz
as code owners
yungezz
reviewed
Apr 7, 2021
| 'resource_skus': '2019-04-01', | ||
| 'disks': '2020-09-30', | ||
| 'disk_encryption_sets': '2020-06-30', | ||
| 'disks': '2020-12-01', |
Member
Author
There was a problem hiding this comment.
No SDK now. I wrote this PR in advance.
yungezz
reviewed
Apr 8, 2021
| namespace='Microsoft.KeyVault', type='vaults', name=source_vault) | ||
| source_vault = SourceVault(id=source_vault) | ||
| keyVault_and_key_reference = KeyVaultAndKeyReference(source_vault=source_vault, key_url=key_url) | ||
| key_vault_and_key_reference = KeyVaultAndKeyReference(source_vault=source_vault, key_url=key_url) |
Member
There was a problem hiding this comment.
minor, but old name makes more sense
| azure-mgmt-cdn==11.0.0 | ||
| azure-mgmt-cognitiveservices==6.3.0 | ||
| azure-mgmt-compute==19.0.0 | ||
| azure-mgmt-compute==20.0.0 |
Member
There was a problem hiding this comment.
does this API contains new version of compute.json?
kairu-ms
approved these changes
Apr 8, 2021
yungezz
approved these changes
Apr 8, 2021
fengzhou-msft
approved these changes
Apr 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolve #17064
Resolve #17063
New API version 2020-12-01
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.